Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Meera Ravindranath, Ronak Kanabar, Patrick Rudolph.
1 comment:
File src/soc/intel/alderlake/romstage/fsp_params.c:
m_cfg->VtdDisable = 0;
m_cfg->VtdIopEnable = 0x1;
if (m_cfg->InternalGfx && GFXVT_BASE_ADDRESS == 0) {
m_cfg->VtdIgdEnable = 0;
printk(BIOS_ERR, "ERROR: Requested IGD VT-d, but GFXVT_BASE_ADDRESS is 0\n");
}
else {
m_cfg->VtdIgdEnable = 0x1;
m_cfg->VtdBaseAddress[0] = GFXVT_BASE_ADDRESS;
}
if (m_cfg->SaIpuEnable && IPUVT_BASE_ADDRESS == 0) {
m_cfg->VtdIpuEnable = 0x0;
printk(BIOS_ERR, "ERROR: Requested IPU VT-d, but IPUVT_BASE_ADDRESS is 0\n");
}
else {
m_cfg->VtdIpuEnable = 0x1;
m_cfg->VtdBaseAddress[1] = IPUVT_BASE_ADDRESS;
}
Let's try to be consistent when specifying boolean values, e.g.
`m_cfg->VtdIgdEnable = 1` is preferred vs. `m_cfg->VtdIgdEnable = 0x1`, but consistency is more important IMO 😊
To view, visit change 51849. To unsubscribe, or for help writing mail filters, visit settings.