View Change

4 comments:

• File src/soc/amd/picasso/Kconfig:

  • Patch Set #7, Line 225: 0x807fff0

    Is this architectural?

    the last 16 bits are architectural; have to look into the first 16 bits, but my guess would be that they are not architectural

• File src/soc/amd/picasso/Makefile.inc:

  • Patch Set #7, Line 44: bootblock-y += smi_util.c

    What's this?

    some functions in there are used by the gpio setup function. will look into this as this indeed smells a bit weird to me

• File src/soc/amd/picasso/bootblock/bootblock.c:

  • Patch Set #7, Line 14: static void amd_initmmio(void)

    If this is only about PCI config space, please name it accordingly. […]

    it is; good catch. removed it and as expected mandolin still boots. will marks as resolved when i've pushed the new version of this patch

  • Patch Set #7, Line 44: i2c_soc_early_init();

    I'm new to AMD. […]

    I'm also rather new to AMD. will look into that

To view, visit change 37490. To unsubscribe, or for help writing mail filters, visit settings.