4 comments:
File src/soc/intel/alderlake/chip.h:
Patch Set #23, Line 26: pcie_rp_flags
A one-line comment for each of these flags would be very helpful.
I left straight ones;)
Patch Set #23, Line 32: PCIE_RP_ALWAYS_ON_CLK
nit: For consistency I think it would be better to name these - […]
Done
File src/soc/intel/alderlake/fsp_params.c:
Patch Set #23, Line 266: pcie_is_flag_enabled
nit: If you add one additional tab before pcie_is_flag_enabled(), it would make it easier to figure […]
Done
File src/soc/intel/alderlake/romstage/fsp_params.c:
nit: extra blank line not required
Done
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.