Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, Arthur Heymans.
View Change
2 comments:
Patchset:
Patch Set #1:
> This is also fixed upstream (https://github.com/lz4/lz4/blob/dev/lib/lz4.c). […]
Generally uprevving sounds fine, but unfortunately in the case of LZ4 it seems that upstream has dropped the in-place decoding support we added (https://github.com/lz4/lz4/pull/185), at least I can't obviously tell that the latest upstream code (which has become quite a bit more complicated) still accounts for this. So if someone wants to uprev it, they would need to do some legwork first to really validate if the latest version still supports in-place properly, or fix it up if it doesn't.
Patchset:
To view, visit change 69091. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82110085c39d001afbdf777481fd7fb1553d731d
Gerrit-Change-Number: 69091
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Comment-Date: Tue, 01 Nov 2022 23:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: comment