Attention is currently required from: Nico Huber, Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Paul Menzel, Subrata Banik, Raj Astekar, Patrick Rudolph.
View Change
5 comments:
Commit Message:
Patch Set #6, Line 21: cat /proc/cpuinfo | grep "apicid"
No need to use cat. ;-) […]
I don't like the grep-only approach, especially when I want to change what I'm grepping for. I prefer to put the path first.
File src/cpu/x86/lapic/lapic_cpu_init.c:
File src/cpu/x86/mp_init.c:
Patch Set #6, Line 458: } else {
Return 0 in the if-block and drop the `else`? This way, you don't need to reindent everything.
Patch Set #6, Line 678: } else {
Simpler:
if (is_x2apic_mode()) {
x2apic_send_ipi(LAPIC_DM_SMI | LAPIC_INT_LEVELTRIG, lapicid());
return;
}
File src/include/cpu/x86/lapic_def.h:
Patch Set #6, Line 99: #define X2APIC_LAPIC_ID (X2APIC_MSR_BASE_ADDRESS | (LAPIC_ID >> 4))
These definitions are misplaced (they're not fields in LAPIC_TDCR, not even LAPIC registers)
To view, visit change 51723. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bb729b0521fb9dc38b7981014755daeaf9ca817
Gerrit-Change-Number: 51723
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu@intel.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu@intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Subrata Banik <subrata.banik@intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar@intel.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Fri, 02 Apr 2021 21:11:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment