28 May
2020
28 May
'20
10:32 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41214 )
Change subject: mb/google/volteer: Reorganize audio codecs ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41214/15/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41214/15/src/mainboard/google/volte... PS15, Line 8: register "irq" = "ACPI_IRQ_EDGE_HIGH(GPP_F8_IRQ)"
I am configuring it in halvor project. […]
This should be ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8), I missed the change from https://review.coreboot.org/c/coreboot/+/41335
--
To view, visit https://review.coreboot.org/c/coreboot/+/41214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic654ea52a549053622603aa8c81fb37577d4e011
Gerrit-Change-Number: 41214
Gerrit-PatchSet: 15
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Sathyanarayana Nujella sathyanarayana.nujella@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 20:32:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-MessageType: comment