Patch Set 9:
(3 comments)
The blob have already been deleted and is marked as "D"
Other comments now implemented
8 comments:
Can you please add 2 or 3 line description regarding what the problem currently is without this chan […]
Done
Patch Set #5, Line 9: Found-by: Google
I am not sure if this is common to add a "Found-by:" line. […]
Done
Patch Set #5, Line 10: BUG=Wrong memory rank info in SMBIOS
Please update this line to "BUG=b:122329046" as Furquan mentioned in one of his previous comments
Done
Patch Set #5, Line 11: TEST=Boot to OS
Seems this change was done to improve the performance. […]
No this change was done to correct the memory information being repported by MOSYS.
Is this Delete intentional? Is it related to the change?
The delete was intentional, it should not be in the patch as mentioned by one reviewer
This should be removed.
It has already been removed. It is marked as "D".
What elese should be done?
File src/soc/intel/common/smbios.h:
dimm?
Done
File src/soc/intel/common/smbios.c:
Patch Set #9, Line 23: rankInDimm
keep this the same as the param name in declaration in smbios. […]
Done
To view, visit change 31235. To unsubscribe, or for help writing mail filters, visit settings.