Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
smbios: TYPE_NONE and TYPE_OTHER are already taken

Change-Id: Ic66f7c919a71cb53773d5056e5f756cd6faf4909
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43135
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/include/smbios.h
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/include/smbios.h b/src/include/smbios.h
index 8283a4c..ed09d64 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -540,7 +540,7 @@

/* enum for port types */
typedef enum {
- TYPE_NONE = 0x00,
+ TYPE_NONE_PORT = 0x00,
TYPE_PARALLEL_PORT_XT_AT_COMPATIBLE = 0x01,
TYPE_PARALLEL_PORT_PS_2 = 0x02,
TYPE_PARALLEL_PORT_ECP = 0x03,
@@ -578,7 +578,7 @@
TYPE_THUNDERBOLT = 0x23,
TYPE_8251_COMPATIBLE = 0xA0,
TYPE_8251_FIFO_COMPATIBLE = 0xA1,
- TYPE_OTHER = 0xFF,
+ TYPE_OTHER_PORT = 0xFF,
} type8_port_types;

struct port_information {

To view, visit change 43135. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic66f7c919a71cb53773d5056e5f756cd6faf4909
Gerrit-Change-Number: 43135
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged