Nico Huber would like Kyösti Mälkki, Aaron Durbin, Arthur Heymans and cedarhouse1@comcast.net to review this change.

View Change

[UNTESTED] cpu/x86/smm: Drop now unused `num_cpus` param

Change-Id: Iebd0a07c3b8dc594296f329038e5c03c21a71dd5
Signed-off-by: Nico Huber <nico.h@gmx.de>
---
M src/cpu/x86/smm/smm_module_loader.c
M src/cpu/x86/smm/smm_stub.S
M src/include/cpu/x86/smm.h
3 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/38767/1

diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index 2ef11340..d4a384a 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -270,7 +270,6 @@
 	stub_params->fxsave_area_size = FXSAVE_SIZE;
 	stub_params->runtime.smbase = (uintptr_t)smbase;
 	stub_params->runtime.save_state_size = params->per_cpu_save_state_size;
-	stub_params->runtime.num_cpus = params->num_concurrent_stacks;
 
 	/* Initialize the APIC id to CPU number table to be 1:1 */
 	for (i = 0; i < params->num_concurrent_stacks; i++)
diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S
index 8207d23..01662b3 100644
--- a/src/cpu/x86/smm/smm_stub.S
+++ b/src/cpu/x86/smm/smm_stub.S
@@ -44,8 +44,6 @@
 .long 0
 save_state_size:
 .long 0
-num_cpus:
-.long 0
 /* allows the STM to bring up SMM in 32-bit mode */
 start32_offset:
 .long smm_trampoline32 - _start
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h
index 9efe2e0..7355a33 100644
--- a/src/include/cpu/x86/smm.h
+++ b/src/include/cpu/x86/smm.h
@@ -64,7 +64,6 @@
 struct smm_runtime {
 	u32 smbase;
 	u32 save_state_size;
-	u32 num_cpus;
 	/* STM's 32bit entry into SMI handler */
 	u32 start32_offset;
 	/* The apic_id_to_cpu provides a mapping from APIC id to CPU number.

To view, visit change 38767. To unsubscribe, or for help writing mail filters, visit settings.