View Change
1 comment:
File src/lib/cbfs.c:
Patch Set #5, Line 330: #if !CONFIG(VBOOT) && CONFIG(VBOOT_MEASURED_BOOT)
I'm not sure this prepare() callback is a good fit for this. […]
The only exact match of "bootblock_main()" is specific to soc/cavium, and every less-exact match is somehow platform-specific. For example, bootblock_main_with_timestamp() in lib/bootblock.c seems used on platforms with C_ENVIRONMENT_BOOTBLOCK selected, while platforms without C_ENVIRONMENT_BOOTBLOCK selected (including most x86 platforms prior to haswell) seem using a romcc-compiled bootblock from either src/arch/x86/bootblock_simple.c or bootblock_normal.c
We had better find a platform-independent location to hook measured_boot_init_crtm(), which is why I initially chose this prepare() callback.
Do you know a more platform-independent location for this?
To view, visit change 35077. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fb376b4a8b98baffaee4d574937797bba1f8aee
Gerrit-Change-Number: 35077
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Joel Kitching <kitching@google.com>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Shawn C <citypw@hardenedlinux.org>
Gerrit-Comment-Date: Mon, 16 Sep 2019 09:24:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment