Attention is currently required from: Angel Pons, Martin L Roth, Paul Menzel.
View Change
1 comment:
Commit Message:
Patch Set #8, Line 15: Tested: Lenovo X220 still boots.
So what needs to be done here to get this batch merged? Can this comment just be resolved?
It could be tested on desktop boards where the introduced conditional evaluates to true. Since the change increases USB TX/RX gains on such boards the USB devices should work even better, not worse. However it might be difficult to test without an oscilloscope attached to create an eye-diagram, as those USB ports might always have been working "okayish".
Marking as resolved to get this merged and let users test it on main.
To view, visit change 78827. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If76e9126b4aba8e16c1c91dece725aac12e1a7e9
Gerrit-Change-Number: 78827
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 14 Jan 2024 07:16:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless@gmail.com>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment