Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, mturney mturney.

View Change

6 comments:

• Commit Message:

  • Patch Set #8, Line 7: sc7280: gpio: eGPIO support on sc7280

    Please use statement (by using a verb in imperative mood) [1], and avoid redundancy.

    qualcomm/sc7280: gpio: Support eGPIO scheme

    [1]: https://chris.beams.io/posts/git-commit/

  • Patch Set #8, Line 15: This change provides an API to configure the eGPIO's.

    Please describe the API.

  • Patch Set #8, Line 18: TEST=Validated on qualcomm sc7280 development board

    How?

• File src/soc/qualcomm/sc7280/include/soc/gpio.h:

  • Patch Set #8, Line 198: EGPIO_CFG_BMSK = 0x1,

    Why hex, when below decimal is used?

• File src/soc/qualcomm/sc7280/sc7280_egpio.c:

  • Patch Set #8, Line 7: int egpio_configure_pins(int start, int end)

    I’d use size_t or unsigned int.

  • Patch Set #8, Line 19: EGPIO_CFG_BMSK)) {

    Fits on the line above.

To view, visit change 55078. To unsubscribe, or for help writing mail filters, visit settings.