Patch Set 2:

(1 comment)

Currently, you can't set wrong values. That's a feature I'd like to
have maintained.

i'll keep that in mind :)

Everything below the currently defined defaults is
wrong.

why are they wrong? I tested it with values below and it behaves like it should.

In other words, this option was hidden on purpose. You can add another
option for instance and take the minimum of both or something like
that. But you mustn't lower it.

An other option would be to adapt the range in the Kconfig or fix the issue which cause this wrong behavior.

View Change

1 comment:

To view, visit change 29979. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice26e2ef349f1172b564edc14f1012c33546a93c
Gerrit-Change-Number: 29979
Gerrit-PatchSet: 2
Gerrit-Owner: Marcello Sylvester Bauer <sylvblck@sylv.io>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck@sylv.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Sat, 01 Dec 2018 23:18:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Marcello Sylvester Bauer <sylvblck@sylv.io>
Gerrit-MessageType: comment