i think in the original patch this was intentional, but i do prefer the version with less code duplication. one thing that would be great to be fixed is that this functionality clubbers the other bits of the register; https://review.coreboot.org/c/coreboot/+/42134 provides functionality to avoid that issue; iirc this issue was one of the motivations for said patch

Patch set 1:Code-Review +1

View Change

To view, visit change 45970. To unsubscribe, or for help writing mail filters, visit settings.