Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31901 )
Change subject: device/root_device: Consolidate common _scan_bus() functions ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31901/1/src/device/root_device.c File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/31901/1/src/device/root_device.c@11... PS1, Line 115: printk(BIOS_SPEW, "%s for %s\n", __func__, dev_path(bus));
Is that what you have in mind / would work: […]
I was very undecided already (because it seems odd to call something scan_xx_bus() when xx has no means of scanning). Then I realized that this gets even worse with scan_usb_bus(). USB is a bus that can be scanned, but that will never be what this function does. IOW, I would change the name anyway, even if we'd keep USB in the name.
So to avoid future confusion, I hope we can just forget that these had different names?
https://review.coreboot.org/c/coreboot/+/31901/2/src/device/root_device.c File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/31901/2/src/device/root_device.c@a1... PS2, Line 126: /** : * Scan root bus for generic systems. : * : * This function is the default scan_bus() method of the root device. : * : * @param root The root device structure. : */
Why was the comment removed? I think it would be helpful to have a comment(if not here, then in devi […]
Ack. I wrote a new comment. I wanted to see where this patch series leads us first. And hoped to integrate scan_smbus() as well. But that's stalled by CB:35456 which I don't like to finish because it will likely be obsolete after next month's code removal.