Patrick Georgi merged this change.
nb/intel/sandybridge: Remove variable set but not used
Change-Id: I75f5d821e018932d3f10d84b7ebed362777fb17d
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32938
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 53f28c6..4974173 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -1452,9 +1452,8 @@
int lane;
FOR_ALL_LANES {
- volatile u32 tmp;
MCHBAR32(0x4340 + 0x400 * channel + 4 * lane) = 0;
- tmp = MCHBAR32(0x4140 + 0x400 * channel + 4 * lane);
+ MCHBAR32(0x4140 + 0x400 * channel + 4 * lane);
}
wait_428c(channel);
@@ -2026,9 +2025,8 @@
MCHBAR32_OR(0x5030, 8);
FOR_ALL_POPULATED_CHANNELS {
- volatile u32 tmp;
MCHBAR32_AND(0x4020 + 0x400 * channel, ~0x00200000);
- tmp = MCHBAR32(0x428c + 0x400 * channel);
+ MCHBAR32(0x428c + 0x400 * channel);
wait_428c(channel);
/* DRAM command ZQCS */
@@ -2373,9 +2371,8 @@
program_timings(ctrl, channel);
FOR_ALL_LANES {
- volatile u32 tmp;
MCHBAR32(0x4340 + 0x400 * channel + 4 * lane) = 0;
- tmp = MCHBAR32(0x400 * channel + 4 * lane + 0x4140);
+ MCHBAR32(0x400 * channel + 4 * lane + 0x4140);
}
wait_428c(channel);
@@ -2454,8 +2451,7 @@
fill_pattern0(ctrl, channel, 0, 0);
MCHBAR32(0x4288 + (channel << 10)) = 0;
FOR_ALL_LANES {
- volatile u32 tmp;
- tmp = MCHBAR32(0x400 * channel + lane * 4 + 0x4140);
+ MCHBAR32(0x400 * channel + lane * 4 + 0x4140);
}
FOR_ALL_POPULATED_RANKS FOR_ALL_LANES {
@@ -2655,10 +2651,9 @@
program_timings(ctrl, channel);
FOR_ALL_LANES {
- volatile u32 tmp;
MCHBAR32(0x4340 + 0x400 * channel +
4 * lane) = 0;
- tmp = MCHBAR32(0x400 * channel +
+ MCHBAR32(0x400 * channel +
4 * lane + 0x4140);
}
wait_428c(channel);
@@ -2703,8 +2698,7 @@
wait_428c(channel);
FOR_ALL_LANES {
- volatile u32 tmp;
- tmp = MCHBAR32(0x4340 +
+ MCHBAR32(0x4340 +
0x400 * channel + lane * 4);
}
To view, visit change 32938. To unsubscribe, or for help writing mail filters, visit settings.