Felix Held submitted this change.

View Change

Approvals: Weimin Wu: Looks good to me, but someone else must approve build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
mb/google/nissa/var/anraggar: Add FW_CONFIG probe for mipi camera

Due to some without mipi camera SKUs can't entering S0i3.

BUG=b:317670018
TEST=suspend_stress_test -c 1

Change-Id: Ifa8649a603c59946b530abd315113b405ceaf35a
Signed-off-by: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79802
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
index a95c763..8fe4316 100644
--- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
@@ -1,3 +1,12 @@
+fw_config
+ field CAMERA 12 13
+ option UF_720P_WF 0
+ option UF_1080P 1
+ option UF_720P 2
+ option UF_1080P_WF 3
+ end
+end
+
chip soc/intel/alderlake
register "sagv" = "SaGv_Enabled"

@@ -210,7 +219,10 @@
register "cio2_lanes_used" = "{4}" # 4 CSI Camera lanes are used
register "cio2_lane_endpoint[0]" = ""^I2C2.CAM0""
register "cio2_prt[0]" = "1"
- device generic 0 on end
+ device generic 0 on
+ probe CAMERA UF_720P_WF
+ probe CAMERA UF_1080P_WF
+ end
end
end
device ref i2c1 on
@@ -281,7 +293,10 @@
register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)"
register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"

- device i2c 36 on end
+ device i2c 36 on
+ probe CAMERA UF_720P_WF
+ probe CAMERA UF_1080P_WF
+ end
end
chip drivers/intel/mipi_camera
register "acpi_uid" = "2"
@@ -303,7 +318,10 @@
register "off_seq.ops_cnt" = "1"
register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"

- device i2c 0C on end
+ device i2c 0C on
+ probe CAMERA UF_720P_WF
+ probe CAMERA UF_1080P_WF
+ end
end
chip drivers/intel/mipi_camera
register "acpi_uid" = "1"
@@ -317,7 +335,10 @@
register "nvm_width" = "0x10"
register "nvm_compat" = ""atmel,24c64""

- device i2c 50 on end
+ device i2c 50 on
+ probe CAMERA UF_720P_WF
+ probe CAMERA UF_1080P_WF
+ end
end
end
device ref i2c3 on

To view, visit change 79802. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifa8649a603c59946b530abd315113b405ceaf35a
Gerrit-Change-Number: 79802
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-MessageType: merged