View Change

2 comments:

• File util/mainboard/google/hatch/create_coreboot_variant.sh:

  • Patch Set #13, Line 54:

    # Start a branch. Use YMD timestamp to avoid collisions.
    DATE=$(date +%Y%m%d)
    repo start "create_${variant}_${DATE}"
    

    Ok, I guess i'd let the user do all the git work, but that's just my own preference. […]

    Those are all good ideas, but not for this revision.

• File util/mainboard/google/hatch/create_coreboot_variant.sh:

  • Patch Set #14, Line 54:

      # Copy a template file to a new name while substituting the
      # current year for __YEAR__
    

    I've had feedback both ways. At first, it said 2019 (as a constant) in the template. […]

    The initial copy of a file to another directory isn't a copyrightable work anyway, but the intent was that when the author came along to make changes to those files for the variant, the copyright would already be correct. Martin has pointed out that Google LLC is already listed in the AUTHORS file, and so the copyright notices are redundant. So, there will be no copyright line, and no __YEAR__ to update.

To view, visit change 35239. To unsubscribe, or for help writing mail filters, visit settings.