Right, you need to actually update all the arm64 memlayouts to include this area, and you should also remove the corresponding mmio_resource() lines from SoC. Otherwise this looks good.

View Change

To view, visit change 31123. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbd9a7fe4b12af23de1519892936d8d88a000e2c
Gerrit-Change-Number: 31123
Gerrit-PatchSet: 2
Gerrit-Owner: Ting Shen <phoenixshen@google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Ting Shen <phoenixshen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 29 Jan 2019 02:07:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment