The board has 2 ROM chips, a 4 MB one and a 2 MB one. Both are connected to the PCH and their contents get treated as one big ROM. The 4 MB one contains the IFD(4 KB), ME(approx 1.4 MB) and beginning of the BIOS region(all remaining space). The 2 MB one contains the rest of the BIOS region. autoport generated the board Kconfig with info about a 6 MB ROM and I just added the definitions to this file. If you have a better suggestion as to what I should do in this case, please tell me and I'll do that instead.

In that case, this is fine. Not your fault that samsung did it that way.

Let's still break this out into 2 separate patches. One patch to add the 6MB ROM and the second to add the mainboard. Let me know if you need help with doing that and I can either do it for you or talk you through it.

View Change

To view, visit change 30942. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843
Gerrit-Change-Number: 30942
Gerrit-PatchSet: 9
Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 17 Jan 2019 21:07:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment