Patch Set 3:

and to clarify, I have gave a comment that you should move your implementation to a different module instead of modifying vpd_decode.c, because at that time I thought you're creating a different VPD format, but from latest implementation it seems not...

And it's still true we don't want people to modify vpd_decode.c since that's a drop from upstream :) it's fine to modify vpd.c if you can have a better utility function in accessing VPD entries.

Makes sense not to touch vpd_decode.c, thanks. For this use case (use VPD data to configure FSP), functions defined in vpd.c is not available.

View Change

To view, visit change 34634. To unsubscribe, or for help writing mail filters, visit settings.