Let's do things in follow up commits. This one is about preventing bricks.
Patch set 1:Code-Review +2
View Change
1 comment:
File firmware.c:
Patch Set #1, Line 203: 4
What if then a HWVER_5 shows up?
In that case I'd like to know even more if it's a GEN1 or a GEN2 (HWVER_GEN[12]a, maybe?) or, in case it's neither, whether it's a HWVER_GEN1_5 or a EM250 Dancing Chicken (HWVER_EM250DC). All of that provides more insight than a simple number IMHO.
But I'm fine with leaving the number around right now until there's a real need to give more context.
To view, visit change 36836. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ia284adca4cb4d341a8d229374b6ea0b5d2a5d5c0
Gerrit-Change-Number: 36836
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 14 Nov 2019 22:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer@coreboot.org>
Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: comment