[coreboot-gerrit] Change in em100[master]: Make firmware update hardware version aware

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36836 )

Change subject: Make firmware update hardware version aware
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

Let's do things in follow up commits. This one is about preventing bricks.

https://review.coreboot.org/c/em100/+/36836/1/firmware.c 
File firmware.c:

https://review.coreboot.org/c/em100/+/36836/1/firmware.c@203 
PS1, Line 203: 4
> What if then a HWVER_5 shows up?

In that case I'd like to know even more if it's a GEN1 or a GEN2 (HWVER_GEN[12]a, maybe?) or, in case it's neither, whether it's a HWVER_GEN1_5 or a EM250 Dancing Chicken (HWVER_EM250DC). All of that provides more insight than a simple number IMHO.

But I'm fine with leaving the number around right now until there's a real need to give more context.