Attention is currently required from: Arthur Heymans, Felix Held, Krishna P Bhat D, Subrata Banik, Wonkyu Kim.

View Change

1 comment:

• File src/drivers/intel/fsp2_0/memory_init.c:

  • Patch Set #6, Line 37: static uint8_t temp_ram[CONFIG_FSP_TEMP_RAM_SIZE] __aligned(16);

    i'd align the stack to 16 bytes in all cases just to be on the safe side and not have different case […]

    Thanks Felix.
    I am making it 16 for both x32 and x64 to be on the safe side as you have suggested. We might end up having few bytes of unused memory in x32 mode due to the 16bytes alignment and I guess that would not have any major impact.

To view, visit change 81661. To unsubscribe, or for help writing mail filters, visit settings.