Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Nico Huber, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak.

Patch set 14:Code-Review +2

View Change

1 comment:

• File src/include/mtcl.h:

  • Patch Set #8, Line 21: __packed

    Added a comment about the struct and how it's meant to be used, as well as why it's explicitly packed. Please reopen if you disagree.

    The code generated should be the same anyway. u8 has no alignment requirements so casting that struct should just always work. But it's ok, LGTM

To view, visit change 80170. To unsubscribe, or for help writing mail filters, visit settings.