I could split this into two patches, one that just hardcodes the DRHD values, and another that "eases" FSP's job. Should I reuse this change ID for DRHD hardcoding or register writes?
based on the commit subject, the former IMO
+1
The latter is really optional, in the best case a no-op and in the
worst a regression (e.g. if FSP misbehaves) and will probably get
some more bikeshedding about where/when it should be done.
Unrelated, what's with the comment style? I'm generally not op-
posed to //, but seeing it added to a file that consistently uses
the other style makes me freak out a little.
1 comment:
File src/soc/intel/skylake/include/soc/systemagent.h:
Patch Set #2, Line 65: Hardcoded default values for PCI Bus:Dev.Fun for IOAPIC and HPET
right, but they appear to be common across multiple Intel SoC's, so I assume it's documented somewhe […]
Not public, in BIOS Writer's Guides mostly. But doesn't matter really, they
just have to be unique within the running system and sync'ed with the ACPI
table.
To view, visit change 35108. To unsubscribe, or for help writing mail filters, visit settings.