Attention is currently required from: Chen-Tsung Hsieh, jitao shi, Shaoming Chen, Jitao Shi.
1 comment:
File src/soc/mediatek/common/dsi.c:
The effect is the same with MIPI_DSI_MODE_EOT_PACKET, 12 byte also.
For Jacuzzi projects, yes you keep it as 12.
But for Kukui projects (NOT using anx7625, NOT enable MIPI_DSI_MODE_EOT_PACKET),
Do we really expect to change it from 12 to 10?
According to the report from analogix, enabling EOTP doesn't always increate 2 bytes, sometimes only 1 byte. So we decide NOT to change timing based on MIPI_DSI_MODE_EOT_PACKET.
I thought the proposed fix from analogix is:
u32 delta = 12;
- if (mode_flags & MIPI_DSI_MODE_EOT_PACKET)
- delta += 2;
-
On the other hand, I checked the driver in kernel.
You use 18 or 12 for the delta according to MIPI_DSI_MODE_VIDEO_BURST.
Without checking MIPI_DSI_MODE_EOT_PACKET.
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/drm/mediatek/mtk_dsi.c#513:
static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi)
{
...
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
if ((vm->hfront_porch + vm->hback_porch) * dsi_tmp_buf_bpp >
data_phy_cycles * dsi->lanes + 18) {
...
}
} else {
if ((vm->hfront_porch + vm->hback_porch) * dsi_tmp_buf_bpp >
data_phy_cycles * dsi->lanes + 12) {
...
}
}
...
}
To view, visit change 51432. To unsubscribe, or for help writing mail filters, visit settings.