2 comments:
File src/soc/mediatek/mt8183/gpio.c:
Patch Set #1, Line 87: MTK_I2C_PIN_SPEC(PAD_SCL5_ID, 20, 18),
nit: There's no need for this macro, if you want to initialize by position you can just write
{PAD_SDA5_ID, 15, 13}
(of course, initializing by position only is hard to read, so you really should write { .id = PAD_SDA5_ID, .eh_bit = 15, .rsel_bit = 13 } explicitly on every line).
Patch Set #1, Line 98: MTK_I2C_PIN_SPEC(PAD_SDA4_ID, 17, 12),
What do these numbers do and where do they come from? Are they specific to the board layout? Why didn't we need this on 8173?
To view, visit change 30974. To unsubscribe, or for help writing mail filters, visit settings.