4 comments:
File src/mainboard/google/kukui/mainboard.c:
Patch Set #45, Line 206: "SPM initialization failed, suspend/resume may fail.\n");
"Failed to init SPM, suspend/resume may fail.\n"
If that exceeds col 80, move to next line.
File src/soc/mediatek/mt8183/spm.c:
if (fw_size == 0)
printk(BIOS_ERR, "SPM file: %s not found!!!\n",
dyna_load_pcm_path[index]);
shouldn't we return now if fw_size is 0?
Patch Set #46, Line 320: = NULL
no need to init since we're not using it before it's assigned.
if (dyna_load_pcm[index].ready)
pcmdesc = &(dyna_load_pcm[index].desc);
else {
printk(BIOS_ERR, "SPM: firmware is not ready!\n");
printk(BIOS_ERR, "SPM: check dram type and firmware version!\n");
return -1;
}
if (!dyna_load_pcm[index].ready) {
printf(BIOS_ERR,...);
...
return -1;
}
pcmdesc = &(...);
To view, visit change 34545. To unsubscribe, or for help writing mail filters, visit settings.