Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41448 )
Change subject: cbfs: add cbfs_boot_locate_file_get_compression_info() ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41448/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41448/1//COMMIT_MSG@10 PS1, Line 10: size) with the current API. Therefore, split cbfs_boot_load_file() up
I can do that. […]
I just don't think it's worth adding right now. I'd prefer to avoid platform-specific code dealing with things like decompression directly wherever possible anyway (things like that tend to be a headache for TOCTOU safety). It would be best if you could just use cbfs_boot_load_file(() for this but I guess the adding to CBMEM doesn't work with that. Maybe we should have a cbfs_load_to_cbmem(name, cbmem_id) or something like that. Haven't fully thought through all the use cases yet.