351 comments:
Patch Set #2, Line 17: void MurmurHash3_x86_32 (const void *key, int len, uint32_t seed, uint32_t *out);
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 16: #define FORCE_INLINE __attribute__((always_inline)) inline
Macros with complex values should be enclosed in parentheses
Patch Set #2, Line 21: static FORCE_INLINE uint32_t rotl32 ( uint32_t x, int8_t r )
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 21: static FORCE_INLINE uint32_t rotl32 ( uint32_t x, int8_t r )
space prohibited after that open parenthesis '('
Patch Set #2, Line 21: static FORCE_INLINE uint32_t rotl32 ( uint32_t x, int8_t r )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 23: return (x << r) | (x >> (32 - r));
please, no spaces at the start of a line
Patch Set #2, Line 26: static FORCE_INLINE uint64_t rotl64 ( uint64_t x, int8_t r )
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 26: static FORCE_INLINE uint64_t rotl64 ( uint64_t x, int8_t r )
space prohibited after that open parenthesis '('
Patch Set #2, Line 26: static FORCE_INLINE uint64_t rotl64 ( uint64_t x, int8_t r )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 28: return (x << r) | (x >> (64 - r));
please, no spaces at the start of a line
Patch Set #2, Line 31: #define ROTL32(x,y) rotl32(x,y)
space required after that ',' (ctx:VxV)
Patch Set #2, Line 31: #define ROTL32(x,y) rotl32(x,y)
space required after that ',' (ctx:VxV)
Patch Set #2, Line 32: #define ROTL64(x,y) rotl64(x,y)
space required after that ',' (ctx:VxV)
Patch Set #2, Line 32: #define ROTL64(x,y) rotl64(x,y)
space required after that ',' (ctx:VxV)
Patch Set #2, Line 45: static FORCE_INLINE uint32_t fmix32 ( uint32_t h )
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 45: static FORCE_INLINE uint32_t fmix32 ( uint32_t h )
space prohibited after that open parenthesis '('
Patch Set #2, Line 45: static FORCE_INLINE uint32_t fmix32 ( uint32_t h )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 47: h ^= h >> 16;
please, no spaces at the start of a line
Patch Set #2, Line 48: h *= 0x85ebca6b;
please, no spaces at the start of a line
Patch Set #2, Line 49: h ^= h >> 13;
please, no spaces at the start of a line
Patch Set #2, Line 50: h *= 0xc2b2ae35;
please, no spaces at the start of a line
Patch Set #2, Line 51: h ^= h >> 16;
please, no spaces at the start of a line
Patch Set #2, Line 53: return h;
please, no spaces at the start of a line
Patch Set #2, Line 58: static FORCE_INLINE uint64_t fmix64 ( uint64_t k )
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 58: static FORCE_INLINE uint64_t fmix64 ( uint64_t k )
space prohibited after that open parenthesis '('
Patch Set #2, Line 58: static FORCE_INLINE uint64_t fmix64 ( uint64_t k )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 60: k ^= k >> 33;
please, no spaces at the start of a line
Patch Set #2, Line 61: k *= BIG_CONSTANT(0xff51afd7ed558ccd);
please, no spaces at the start of a line
Patch Set #2, Line 62: k ^= k >> 33;
please, no spaces at the start of a line
Patch Set #2, Line 63: k *= BIG_CONSTANT(0xc4ceb9fe1a85ec53);
please, no spaces at the start of a line
Patch Set #2, Line 64: k ^= k >> 33;
please, no spaces at the start of a line
Patch Set #2, Line 66: return k;
please, no spaces at the start of a line
Patch Set #2, Line 71: void MurmurHash3_x86_32 ( const void * key, int len,
"foo * bar" should be "foo *bar"
Patch Set #2, Line 71: void MurmurHash3_x86_32 ( const void * key, int len,
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 71: void MurmurHash3_x86_32 ( const void * key, int len,
space prohibited after that open parenthesis '('
Patch Set #2, Line 72: uint32_t seed, uint32_t * out )
code indent should use tabs where possible
Patch Set #2, Line 72: uint32_t seed, uint32_t * out )
please, no spaces at the start of a line
Patch Set #2, Line 72: uint32_t seed, uint32_t * out )
"foo * bar" should be "foo *bar"
Patch Set #2, Line 72: uint32_t seed, uint32_t * out )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 74: const uint8_t * data = (const uint8_t*)key;
please, no spaces at the start of a line
Patch Set #2, Line 74: const uint8_t * data = (const uint8_t*)key;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 74: const uint8_t * data = (const uint8_t*)key;
"foo * bar" should be "foo *bar"
Patch Set #2, Line 75: const int nblocks = len / 4;
please, no spaces at the start of a line
Patch Set #2, Line 76: int i;
please, no spaces at the start of a line
Patch Set #2, Line 78: uint32_t h1 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 80: uint32_t c1 = 0xcc9e2d51;
please, no spaces at the start of a line
Patch Set #2, Line 81: uint32_t c2 = 0x1b873593;
please, no spaces at the start of a line
Patch Set #2, Line 86: const uint32_t * blocks = (const uint32_t *)(data + nblocks*4);
please, no spaces at the start of a line
Patch Set #2, Line 86: const uint32_t * blocks = (const uint32_t *)(data + nblocks*4);
"foo * bar" should be "foo *bar"
Patch Set #2, Line 88: for(i = -nblocks; i; i++)
please, no spaces at the start of a line
Patch Set #2, Line 88: for(i = -nblocks; i; i++)
that open brace { should be on the previous line
Patch Set #2, Line 88: for(i = -nblocks; i; i++)
suspect code indent for conditional statements (2, 4)
Patch Set #2, Line 88: for(i = -nblocks; i; i++)
space required before the open parenthesis '('
please, no spaces at the start of a line
Patch Set #2, Line 90: uint32_t k1 = getblock(blocks,i);
please, no spaces at the start of a line
Patch Set #2, Line 90: uint32_t k1 = getblock(blocks,i);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 92: k1 *= c1;
please, no spaces at the start of a line
Patch Set #2, Line 93: k1 = ROTL32(k1,15);
please, no spaces at the start of a line
Patch Set #2, Line 93: k1 = ROTL32(k1,15);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 94: k1 *= c2;
please, no spaces at the start of a line
Patch Set #2, Line 96: h1 ^= k1;
please, no spaces at the start of a line
Patch Set #2, Line 97: h1 = ROTL32(h1,13);
please, no spaces at the start of a line
Patch Set #2, Line 97: h1 = ROTL32(h1,13);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 98: h1 = h1*5+0xe6546b64;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #2, Line 104: const uint8_t * tail = (const uint8_t*)(data + nblocks*4);
please, no spaces at the start of a line
Patch Set #2, Line 104: const uint8_t * tail = (const uint8_t*)(data + nblocks*4);
"(foo*)" should be "(foo *)"
Patch Set #2, Line 104: const uint8_t * tail = (const uint8_t*)(data + nblocks*4);
"foo * bar" should be "foo *bar"
Patch Set #2, Line 106: uint32_t k1 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 108: switch(len & 3)
please, no spaces at the start of a line
Patch Set #2, Line 108: switch(len & 3)
that open brace { should be on the previous line
Patch Set #2, Line 108: switch(len & 3)
space required before the open parenthesis '('
please, no spaces at the start of a line
Patch Set #2, Line 110: case 3: k1 ^= tail[2] << 16;
please, no spaces at the start of a line
Patch Set #2, Line 110: case 3: k1 ^= tail[2] << 16;
trailing statements should be on next line
Patch Set #2, Line 111: case 2: k1 ^= tail[1] << 8;
please, no spaces at the start of a line
Patch Set #2, Line 111: case 2: k1 ^= tail[1] << 8;
trailing statements should be on next line
Patch Set #2, Line 112: case 1: k1 ^= tail[0];
please, no spaces at the start of a line
Patch Set #2, Line 112: case 1: k1 ^= tail[0];
trailing statements should be on next line
Patch Set #2, Line 112: case 1: k1 ^= tail[0];
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 113: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
code indent should use tabs where possible
Patch Set #2, Line 113: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
please, no spaces at the start of a line
Patch Set #2, Line 113: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
space required after that ',' (ctx:VxV)
please, no spaces at the start of a line
Patch Set #2, Line 119: h1 ^= len;
please, no spaces at the start of a line
Patch Set #2, Line 121: h1 = fmix32(h1);
please, no spaces at the start of a line
Patch Set #2, Line 123: *(uint32_t*)out = h1;
please, no spaces at the start of a line
Patch Set #2, Line 123: *(uint32_t*)out = h1;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 128: void MurmurHash3_x86_128 ( const void * key, const int len,
"foo * bar" should be "foo *bar"
Patch Set #2, Line 128: void MurmurHash3_x86_128 ( const void * key, const int len,
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 128: void MurmurHash3_x86_128 ( const void * key, const int len,
space prohibited after that open parenthesis '('
Patch Set #2, Line 129: uint32_t seed, void * out )
code indent should use tabs where possible
Patch Set #2, Line 129: uint32_t seed, void * out )
please, no spaces at the start of a line
Patch Set #2, Line 129: uint32_t seed, void * out )
"foo * bar" should be "foo *bar"
Patch Set #2, Line 129: uint32_t seed, void * out )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 131: const uint8_t * data = (const uint8_t*)key;
please, no spaces at the start of a line
Patch Set #2, Line 131: const uint8_t * data = (const uint8_t*)key;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 131: const uint8_t * data = (const uint8_t*)key;
"foo * bar" should be "foo *bar"
Patch Set #2, Line 132: const int nblocks = len / 16;
please, no spaces at the start of a line
Patch Set #2, Line 133: int i;
please, no spaces at the start of a line
Patch Set #2, Line 135: uint32_t h1 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 136: uint32_t h2 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 137: uint32_t h3 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 138: uint32_t h4 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 140: uint32_t c1 = 0x239b961b;
please, no spaces at the start of a line
Patch Set #2, Line 141: uint32_t c2 = 0xab0e9789;
please, no spaces at the start of a line
Patch Set #2, Line 142: uint32_t c3 = 0x38b34ae5;
please, no spaces at the start of a line
Patch Set #2, Line 143: uint32_t c4 = 0xa1e38b93;
please, no spaces at the start of a line
Patch Set #2, Line 148: const uint32_t * blocks = (const uint32_t *)(data + nblocks*16);
please, no spaces at the start of a line
Patch Set #2, Line 148: const uint32_t * blocks = (const uint32_t *)(data + nblocks*16);
"foo * bar" should be "foo *bar"
Patch Set #2, Line 150: for(i = -nblocks; i; i++)
please, no spaces at the start of a line
Patch Set #2, Line 150: for(i = -nblocks; i; i++)
that open brace { should be on the previous line
Patch Set #2, Line 150: for(i = -nblocks; i; i++)
suspect code indent for conditional statements (2, 4)
Patch Set #2, Line 150: for(i = -nblocks; i; i++)
space required before the open parenthesis '('
please, no spaces at the start of a line
Patch Set #2, Line 152: uint32_t k1 = getblock(blocks,i*4+0);
please, no spaces at the start of a line
Patch Set #2, Line 152: uint32_t k1 = getblock(blocks,i*4+0);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 153: uint32_t k2 = getblock(blocks,i*4+1);
please, no spaces at the start of a line
Patch Set #2, Line 153: uint32_t k2 = getblock(blocks,i*4+1);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 154: uint32_t k3 = getblock(blocks,i*4+2);
please, no spaces at the start of a line
Patch Set #2, Line 154: uint32_t k3 = getblock(blocks,i*4+2);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 155: uint32_t k4 = getblock(blocks,i*4+3);
please, no spaces at the start of a line
Patch Set #2, Line 155: uint32_t k4 = getblock(blocks,i*4+3);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 157: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
please, no spaces at the start of a line
Patch Set #2, Line 157: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 159: h1 = ROTL32(h1,19); h1 += h2; h1 = h1*5+0x561ccd1b;
please, no spaces at the start of a line
Patch Set #2, Line 159: h1 = ROTL32(h1,19); h1 += h2; h1 = h1*5+0x561ccd1b;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 161: k2 *= c2; k2 = ROTL32(k2,16); k2 *= c3; h2 ^= k2;
please, no spaces at the start of a line
Patch Set #2, Line 161: k2 *= c2; k2 = ROTL32(k2,16); k2 *= c3; h2 ^= k2;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 163: h2 = ROTL32(h2,17); h2 += h3; h2 = h2*5+0x0bcaa747;
please, no spaces at the start of a line
Patch Set #2, Line 163: h2 = ROTL32(h2,17); h2 += h3; h2 = h2*5+0x0bcaa747;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 165: k3 *= c3; k3 = ROTL32(k3,17); k3 *= c4; h3 ^= k3;
please, no spaces at the start of a line
Patch Set #2, Line 165: k3 *= c3; k3 = ROTL32(k3,17); k3 *= c4; h3 ^= k3;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 167: h3 = ROTL32(h3,15); h3 += h4; h3 = h3*5+0x96cd1c35;
please, no spaces at the start of a line
Patch Set #2, Line 167: h3 = ROTL32(h3,15); h3 += h4; h3 = h3*5+0x96cd1c35;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 169: k4 *= c4; k4 = ROTL32(k4,18); k4 *= c1; h4 ^= k4;
please, no spaces at the start of a line
Patch Set #2, Line 169: k4 *= c4; k4 = ROTL32(k4,18); k4 *= c1; h4 ^= k4;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 171: h4 = ROTL32(h4,13); h4 += h1; h4 = h4*5+0x32ac3b17;
please, no spaces at the start of a line
Patch Set #2, Line 171: h4 = ROTL32(h4,13); h4 += h1; h4 = h4*5+0x32ac3b17;
space required after that ',' (ctx:VxV)
please, no spaces at the start of a line
Patch Set #2, Line 177: const uint8_t * tail = (const uint8_t*)(data + nblocks*16);
please, no spaces at the start of a line
Patch Set #2, Line 177: const uint8_t * tail = (const uint8_t*)(data + nblocks*16);
"(foo*)" should be "(foo *)"
Patch Set #2, Line 177: const uint8_t * tail = (const uint8_t*)(data + nblocks*16);
"foo * bar" should be "foo *bar"
Patch Set #2, Line 179: uint32_t k1 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 180: uint32_t k2 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 181: uint32_t k3 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 182: uint32_t k4 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 184: switch(len & 15)
please, no spaces at the start of a line
Patch Set #2, Line 184: switch(len & 15)
that open brace { should be on the previous line
Patch Set #2, Line 184: switch(len & 15)
space required before the open parenthesis '('
please, no spaces at the start of a line
Patch Set #2, Line 186: case 15: k4 ^= tail[14] << 16;
please, no spaces at the start of a line
Patch Set #2, Line 186: case 15: k4 ^= tail[14] << 16;
trailing statements should be on next line
Patch Set #2, Line 187: case 14: k4 ^= tail[13] << 8;
please, no spaces at the start of a line
Patch Set #2, Line 187: case 14: k4 ^= tail[13] << 8;
trailing statements should be on next line
Patch Set #2, Line 188: case 13: k4 ^= tail[12] << 0;
please, no spaces at the start of a line
Patch Set #2, Line 188: case 13: k4 ^= tail[12] << 0;
trailing statements should be on next line
Patch Set #2, Line 188: case 13: k4 ^= tail[12] << 0;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 189: k4 *= c4; k4 = ROTL32(k4,18); k4 *= c1; h4 ^= k4;
code indent should use tabs where possible
Patch Set #2, Line 189: k4 *= c4; k4 = ROTL32(k4,18); k4 *= c1; h4 ^= k4;
please, no spaces at the start of a line
Patch Set #2, Line 189: k4 *= c4; k4 = ROTL32(k4,18); k4 *= c1; h4 ^= k4;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 191: case 12: k3 ^= tail[11] << 24;
please, no spaces at the start of a line
Patch Set #2, Line 191: case 12: k3 ^= tail[11] << 24;
trailing statements should be on next line
Patch Set #2, Line 191: case 12: k3 ^= tail[11] << 24;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 192: case 11: k3 ^= tail[10] << 16;
please, no spaces at the start of a line
Patch Set #2, Line 192: case 11: k3 ^= tail[10] << 16;
trailing statements should be on next line
Patch Set #2, Line 192: case 11: k3 ^= tail[10] << 16;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 193: case 10: k3 ^= tail[ 9] << 8;
please, no spaces at the start of a line
Patch Set #2, Line 193: case 10: k3 ^= tail[ 9] << 8;
space prohibited after that open square bracket '['
Patch Set #2, Line 193: case 10: k3 ^= tail[ 9] << 8;
trailing statements should be on next line
Patch Set #2, Line 193: case 10: k3 ^= tail[ 9] << 8;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 194: case 9: k3 ^= tail[ 8] << 0;
please, no spaces at the start of a line
Patch Set #2, Line 194: case 9: k3 ^= tail[ 8] << 0;
space prohibited after that open square bracket '['
Patch Set #2, Line 194: case 9: k3 ^= tail[ 8] << 0;
trailing statements should be on next line
Patch Set #2, Line 194: case 9: k3 ^= tail[ 8] << 0;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 195: k3 *= c3; k3 = ROTL32(k3,17); k3 *= c4; h3 ^= k3;
code indent should use tabs where possible
Patch Set #2, Line 195: k3 *= c3; k3 = ROTL32(k3,17); k3 *= c4; h3 ^= k3;
please, no spaces at the start of a line
Patch Set #2, Line 195: k3 *= c3; k3 = ROTL32(k3,17); k3 *= c4; h3 ^= k3;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 197: case 8: k2 ^= tail[ 7] << 24;
please, no spaces at the start of a line
Patch Set #2, Line 197: case 8: k2 ^= tail[ 7] << 24;
space prohibited after that open square bracket '['
Patch Set #2, Line 197: case 8: k2 ^= tail[ 7] << 24;
trailing statements should be on next line
Patch Set #2, Line 197: case 8: k2 ^= tail[ 7] << 24;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 198: case 7: k2 ^= tail[ 6] << 16;
please, no spaces at the start of a line
Patch Set #2, Line 198: case 7: k2 ^= tail[ 6] << 16;
space prohibited after that open square bracket '['
Patch Set #2, Line 198: case 7: k2 ^= tail[ 6] << 16;
trailing statements should be on next line
Patch Set #2, Line 198: case 7: k2 ^= tail[ 6] << 16;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 199: case 6: k2 ^= tail[ 5] << 8;
please, no spaces at the start of a line
Patch Set #2, Line 199: case 6: k2 ^= tail[ 5] << 8;
space prohibited after that open square bracket '['
Patch Set #2, Line 199: case 6: k2 ^= tail[ 5] << 8;
trailing statements should be on next line
Patch Set #2, Line 199: case 6: k2 ^= tail[ 5] << 8;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 200: case 5: k2 ^= tail[ 4] << 0;
please, no spaces at the start of a line
Patch Set #2, Line 200: case 5: k2 ^= tail[ 4] << 0;
space prohibited after that open square bracket '['
Patch Set #2, Line 200: case 5: k2 ^= tail[ 4] << 0;
trailing statements should be on next line
Patch Set #2, Line 200: case 5: k2 ^= tail[ 4] << 0;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 201: k2 *= c2; k2 = ROTL32(k2,16); k2 *= c3; h2 ^= k2;
code indent should use tabs where possible
Patch Set #2, Line 201: k2 *= c2; k2 = ROTL32(k2,16); k2 *= c3; h2 ^= k2;
please, no spaces at the start of a line
Patch Set #2, Line 201: k2 *= c2; k2 = ROTL32(k2,16); k2 *= c3; h2 ^= k2;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 203: case 4: k1 ^= tail[ 3] << 24;
please, no spaces at the start of a line
Patch Set #2, Line 203: case 4: k1 ^= tail[ 3] << 24;
space prohibited after that open square bracket '['
Patch Set #2, Line 203: case 4: k1 ^= tail[ 3] << 24;
trailing statements should be on next line
Patch Set #2, Line 203: case 4: k1 ^= tail[ 3] << 24;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 204: case 3: k1 ^= tail[ 2] << 16;
please, no spaces at the start of a line
Patch Set #2, Line 204: case 3: k1 ^= tail[ 2] << 16;
space prohibited after that open square bracket '['
Patch Set #2, Line 204: case 3: k1 ^= tail[ 2] << 16;
trailing statements should be on next line
Patch Set #2, Line 204: case 3: k1 ^= tail[ 2] << 16;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 205: case 2: k1 ^= tail[ 1] << 8;
please, no spaces at the start of a line
Patch Set #2, Line 205: case 2: k1 ^= tail[ 1] << 8;
space prohibited after that open square bracket '['
Patch Set #2, Line 205: case 2: k1 ^= tail[ 1] << 8;
trailing statements should be on next line
Patch Set #2, Line 205: case 2: k1 ^= tail[ 1] << 8;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 206: case 1: k1 ^= tail[ 0] << 0;
please, no spaces at the start of a line
Patch Set #2, Line 206: case 1: k1 ^= tail[ 0] << 0;
space prohibited after that open square bracket '['
Patch Set #2, Line 206: case 1: k1 ^= tail[ 0] << 0;
trailing statements should be on next line
Patch Set #2, Line 206: case 1: k1 ^= tail[ 0] << 0;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 207: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
code indent should use tabs where possible
Patch Set #2, Line 207: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
please, no spaces at the start of a line
Patch Set #2, Line 207: k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1;
space required after that ',' (ctx:VxV)
please, no spaces at the start of a line
Patch Set #2, Line 213: h1 ^= len; h2 ^= len; h3 ^= len; h4 ^= len;
please, no spaces at the start of a line
Patch Set #2, Line 215: h1 += h2; h1 += h3; h1 += h4;
please, no spaces at the start of a line
Patch Set #2, Line 216: h2 += h1; h3 += h1; h4 += h1;
please, no spaces at the start of a line
Patch Set #2, Line 218: h1 = fmix32(h1);
please, no spaces at the start of a line
Patch Set #2, Line 219: h2 = fmix32(h2);
please, no spaces at the start of a line
Patch Set #2, Line 220: h3 = fmix32(h3);
please, no spaces at the start of a line
Patch Set #2, Line 221: h4 = fmix32(h4);
please, no spaces at the start of a line
Patch Set #2, Line 223: h1 += h2; h1 += h3; h1 += h4;
please, no spaces at the start of a line
Patch Set #2, Line 224: h2 += h1; h3 += h1; h4 += h1;
please, no spaces at the start of a line
Patch Set #2, Line 226: ((uint32_t*)out)[0] = h1;
please, no spaces at the start of a line
Patch Set #2, Line 226: ((uint32_t*)out)[0] = h1;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 227: ((uint32_t*)out)[1] = h2;
please, no spaces at the start of a line
Patch Set #2, Line 227: ((uint32_t*)out)[1] = h2;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 228: ((uint32_t*)out)[2] = h3;
please, no spaces at the start of a line
Patch Set #2, Line 228: ((uint32_t*)out)[2] = h3;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 229: ((uint32_t*)out)[3] = h4;
please, no spaces at the start of a line
Patch Set #2, Line 229: ((uint32_t*)out)[3] = h4;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 234: void MurmurHash3_x64_128 ( const void * key, const int len,
"foo * bar" should be "foo *bar"
Patch Set #2, Line 234: void MurmurHash3_x64_128 ( const void * key, const int len,
space prohibited between function name and open parenthesis '('
Patch Set #2, Line 234: void MurmurHash3_x64_128 ( const void * key, const int len,
space prohibited after that open parenthesis '('
Patch Set #2, Line 235: const uint32_t seed, void * out )
code indent should use tabs where possible
Patch Set #2, Line 235: const uint32_t seed, void * out )
please, no spaces at the start of a line
Patch Set #2, Line 235: const uint32_t seed, void * out )
"foo * bar" should be "foo *bar"
Patch Set #2, Line 235: const uint32_t seed, void * out )
space prohibited before that close parenthesis ')'
Patch Set #2, Line 237: const uint8_t * data = (const uint8_t*)key;
please, no spaces at the start of a line
Patch Set #2, Line 237: const uint8_t * data = (const uint8_t*)key;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 237: const uint8_t * data = (const uint8_t*)key;
"foo * bar" should be "foo *bar"
Patch Set #2, Line 238: const int nblocks = len / 16;
please, no spaces at the start of a line
Patch Set #2, Line 239: int i;
please, no spaces at the start of a line
Patch Set #2, Line 241: uint64_t h1 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 242: uint64_t h2 = seed;
please, no spaces at the start of a line
Patch Set #2, Line 244: uint64_t c1 = BIG_CONSTANT(0x87c37b91114253d5);
please, no spaces at the start of a line
Patch Set #2, Line 245: uint64_t c2 = BIG_CONSTANT(0x4cf5ad432745937f);
please, no spaces at the start of a line
Patch Set #2, Line 250: const uint64_t * blocks = (const uint64_t *)(data);
please, no spaces at the start of a line
Patch Set #2, Line 250: const uint64_t * blocks = (const uint64_t *)(data);
"foo * bar" should be "foo *bar"
Patch Set #2, Line 252: for(i = 0; i < nblocks; i++)
please, no spaces at the start of a line
Patch Set #2, Line 252: for(i = 0; i < nblocks; i++)
that open brace { should be on the previous line
Patch Set #2, Line 252: for(i = 0; i < nblocks; i++)
suspect code indent for conditional statements (2, 4)
Patch Set #2, Line 252: for(i = 0; i < nblocks; i++)
space required before the open parenthesis '('
please, no spaces at the start of a line
Patch Set #2, Line 254: uint64_t k1 = getblock(blocks,i*2+0);
please, no spaces at the start of a line
Patch Set #2, Line 254: uint64_t k1 = getblock(blocks,i*2+0);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 255: uint64_t k2 = getblock(blocks,i*2+1);
please, no spaces at the start of a line
Patch Set #2, Line 255: uint64_t k2 = getblock(blocks,i*2+1);
space required after that ',' (ctx:VxV)
Patch Set #2, Line 257: k1 *= c1; k1 = ROTL64(k1,31); k1 *= c2; h1 ^= k1;
please, no spaces at the start of a line
Patch Set #2, Line 257: k1 *= c1; k1 = ROTL64(k1,31); k1 *= c2; h1 ^= k1;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 259: h1 = ROTL64(h1,27); h1 += h2; h1 = h1*5+0x52dce729;
please, no spaces at the start of a line
Patch Set #2, Line 259: h1 = ROTL64(h1,27); h1 += h2; h1 = h1*5+0x52dce729;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 261: k2 *= c2; k2 = ROTL64(k2,33); k2 *= c1; h2 ^= k2;
please, no spaces at the start of a line
Patch Set #2, Line 261: k2 *= c2; k2 = ROTL64(k2,33); k2 *= c1; h2 ^= k2;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 263: h2 = ROTL64(h2,31); h2 += h1; h2 = h2*5+0x38495ab5;
please, no spaces at the start of a line
Patch Set #2, Line 263: h2 = ROTL64(h2,31); h2 += h1; h2 = h2*5+0x38495ab5;
space required after that ',' (ctx:VxV)
please, no spaces at the start of a line
Patch Set #2, Line 269: const uint8_t * tail = (const uint8_t*)(data + nblocks*16);
please, no spaces at the start of a line
Patch Set #2, Line 269: const uint8_t * tail = (const uint8_t*)(data + nblocks*16);
"(foo*)" should be "(foo *)"
Patch Set #2, Line 269: const uint8_t * tail = (const uint8_t*)(data + nblocks*16);
"foo * bar" should be "foo *bar"
Patch Set #2, Line 271: uint64_t k1 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 272: uint64_t k2 = 0;
please, no spaces at the start of a line
Patch Set #2, Line 274: switch(len & 15)
please, no spaces at the start of a line
Patch Set #2, Line 274: switch(len & 15)
that open brace { should be on the previous line
Patch Set #2, Line 274: switch(len & 15)
space required before the open parenthesis '('
please, no spaces at the start of a line
Patch Set #2, Line 276: case 15: k2 ^= (uint64_t)(tail[14]) << 48;
please, no spaces at the start of a line
Patch Set #2, Line 276: case 15: k2 ^= (uint64_t)(tail[14]) << 48;
trailing statements should be on next line
Patch Set #2, Line 277: case 14: k2 ^= (uint64_t)(tail[13]) << 40;
please, no spaces at the start of a line
Patch Set #2, Line 277: case 14: k2 ^= (uint64_t)(tail[13]) << 40;
trailing statements should be on next line
Patch Set #2, Line 278: case 13: k2 ^= (uint64_t)(tail[12]) << 32;
please, no spaces at the start of a line
Patch Set #2, Line 278: case 13: k2 ^= (uint64_t)(tail[12]) << 32;
trailing statements should be on next line
Patch Set #2, Line 278: case 13: k2 ^= (uint64_t)(tail[12]) << 32;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 279: case 12: k2 ^= (uint64_t)(tail[11]) << 24;
please, no spaces at the start of a line
Patch Set #2, Line 279: case 12: k2 ^= (uint64_t)(tail[11]) << 24;
trailing statements should be on next line
Patch Set #2, Line 279: case 12: k2 ^= (uint64_t)(tail[11]) << 24;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 280: case 11: k2 ^= (uint64_t)(tail[10]) << 16;
please, no spaces at the start of a line
Patch Set #2, Line 280: case 11: k2 ^= (uint64_t)(tail[10]) << 16;
trailing statements should be on next line
Patch Set #2, Line 280: case 11: k2 ^= (uint64_t)(tail[10]) << 16;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 281: case 10: k2 ^= (uint64_t)(tail[ 9]) << 8;
please, no spaces at the start of a line
Patch Set #2, Line 281: case 10: k2 ^= (uint64_t)(tail[ 9]) << 8;
space prohibited after that open square bracket '['
Patch Set #2, Line 281: case 10: k2 ^= (uint64_t)(tail[ 9]) << 8;
trailing statements should be on next line
Patch Set #2, Line 281: case 10: k2 ^= (uint64_t)(tail[ 9]) << 8;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 282: case 9: k2 ^= (uint64_t)(tail[ 8]) << 0;
please, no spaces at the start of a line
Patch Set #2, Line 282: case 9: k2 ^= (uint64_t)(tail[ 8]) << 0;
space prohibited after that open square bracket '['
Patch Set #2, Line 282: case 9: k2 ^= (uint64_t)(tail[ 8]) << 0;
trailing statements should be on next line
Patch Set #2, Line 282: case 9: k2 ^= (uint64_t)(tail[ 8]) << 0;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 283: k2 *= c2; k2 = ROTL64(k2,33); k2 *= c1; h2 ^= k2;
code indent should use tabs where possible
Patch Set #2, Line 283: k2 *= c2; k2 = ROTL64(k2,33); k2 *= c1; h2 ^= k2;
please, no spaces at the start of a line
Patch Set #2, Line 283: k2 *= c2; k2 = ROTL64(k2,33); k2 *= c1; h2 ^= k2;
space required after that ',' (ctx:VxV)
Patch Set #2, Line 285: case 8: k1 ^= (uint64_t)(tail[ 7]) << 56;
please, no spaces at the start of a line
Patch Set #2, Line 285: case 8: k1 ^= (uint64_t)(tail[ 7]) << 56;
space prohibited after that open square bracket '['
Patch Set #2, Line 285: case 8: k1 ^= (uint64_t)(tail[ 7]) << 56;
trailing statements should be on next line
Patch Set #2, Line 285: case 8: k1 ^= (uint64_t)(tail[ 7]) << 56;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 286: case 7: k1 ^= (uint64_t)(tail[ 6]) << 48;
please, no spaces at the start of a line
Patch Set #2, Line 286: case 7: k1 ^= (uint64_t)(tail[ 6]) << 48;
space prohibited after that open square bracket '['
Patch Set #2, Line 286: case 7: k1 ^= (uint64_t)(tail[ 6]) << 48;
trailing statements should be on next line
Patch Set #2, Line 286: case 7: k1 ^= (uint64_t)(tail[ 6]) << 48;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 287: case 6: k1 ^= (uint64_t)(tail[ 5]) << 40;
please, no spaces at the start of a line
Patch Set #2, Line 287: case 6: k1 ^= (uint64_t)(tail[ 5]) << 40;
space prohibited after that open square bracket '['
Patch Set #2, Line 287: case 6: k1 ^= (uint64_t)(tail[ 5]) << 40;
trailing statements should be on next line
Patch Set #2, Line 287: case 6: k1 ^= (uint64_t)(tail[ 5]) << 40;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 288: case 5: k1 ^= (uint64_t)(tail[ 4]) << 32;
please, no spaces at the start of a line
Patch Set #2, Line 288: case 5: k1 ^= (uint64_t)(tail[ 4]) << 32;
space prohibited after that open square bracket '['
Patch Set #2, Line 288: case 5: k1 ^= (uint64_t)(tail[ 4]) << 32;
trailing statements should be on next line
Patch Set #2, Line 288: case 5: k1 ^= (uint64_t)(tail[ 4]) << 32;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 289: case 4: k1 ^= (uint64_t)(tail[ 3]) << 24;
please, no spaces at the start of a line
Patch Set #2, Line 289: case 4: k1 ^= (uint64_t)(tail[ 3]) << 24;
space prohibited after that open square bracket '['
Patch Set #2, Line 289: case 4: k1 ^= (uint64_t)(tail[ 3]) << 24;
trailing statements should be on next line
Patch Set #2, Line 289: case 4: k1 ^= (uint64_t)(tail[ 3]) << 24;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 290: case 3: k1 ^= (uint64_t)(tail[ 2]) << 16;
please, no spaces at the start of a line
Patch Set #2, Line 290: case 3: k1 ^= (uint64_t)(tail[ 2]) << 16;
space prohibited after that open square bracket '['
Patch Set #2, Line 290: case 3: k1 ^= (uint64_t)(tail[ 2]) << 16;
trailing statements should be on next line
Patch Set #2, Line 290: case 3: k1 ^= (uint64_t)(tail[ 2]) << 16;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 291: case 2: k1 ^= (uint64_t)(tail[ 1]) << 8;
please, no spaces at the start of a line
Patch Set #2, Line 291: case 2: k1 ^= (uint64_t)(tail[ 1]) << 8;
space prohibited after that open square bracket '['
Patch Set #2, Line 291: case 2: k1 ^= (uint64_t)(tail[ 1]) << 8;
trailing statements should be on next line
Patch Set #2, Line 291: case 2: k1 ^= (uint64_t)(tail[ 1]) << 8;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 292: case 1: k1 ^= (uint64_t)(tail[ 0]) << 0;
please, no spaces at the start of a line
Patch Set #2, Line 292: case 1: k1 ^= (uint64_t)(tail[ 0]) << 0;
space prohibited after that open square bracket '['
Patch Set #2, Line 292: case 1: k1 ^= (uint64_t)(tail[ 0]) << 0;
trailing statements should be on next line
Patch Set #2, Line 292: case 1: k1 ^= (uint64_t)(tail[ 0]) << 0;
Possible switch case/default not preceded by break or fallthrough comment
Patch Set #2, Line 293: k1 *= c1; k1 = ROTL64(k1,31); k1 *= c2; h1 ^= k1;
code indent should use tabs where possible
Patch Set #2, Line 293: k1 *= c1; k1 = ROTL64(k1,31); k1 *= c2; h1 ^= k1;
please, no spaces at the start of a line
Patch Set #2, Line 293: k1 *= c1; k1 = ROTL64(k1,31); k1 *= c2; h1 ^= k1;
space required after that ',' (ctx:VxV)
please, no spaces at the start of a line
Patch Set #2, Line 299: h1 ^= len; h2 ^= len;
please, no spaces at the start of a line
Patch Set #2, Line 301: h1 += h2;
please, no spaces at the start of a line
Patch Set #2, Line 302: h2 += h1;
please, no spaces at the start of a line
Patch Set #2, Line 304: h1 = fmix64(h1);
please, no spaces at the start of a line
Patch Set #2, Line 305: h2 = fmix64(h2);
please, no spaces at the start of a line
Patch Set #2, Line 307: h1 += h2;
please, no spaces at the start of a line
Patch Set #2, Line 308: h2 += h1;
please, no spaces at the start of a line
Patch Set #2, Line 310: ((uint64_t*)out)[0] = h1;
please, no spaces at the start of a line
Patch Set #2, Line 310: ((uint64_t*)out)[0] = h1;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 311: ((uint64_t*)out)[1] = h2;
please, no spaces at the start of a line
Patch Set #2, Line 311: ((uint64_t*)out)[1] = h2;
"(foo*)" should be "(foo *)"
Patch Set #2, Line 199: void verify_ram()
Bad function definition - void verify_ram() should probably be void verify_ram(void)
To view, visit change 42890. To unsubscribe, or for help writing mail filters, visit settings.