Attention is currently required from: Cliff Huang, Lance Zhao, Patrick Rudolph, Subrata Banik, Tim Wawrzynczak, yuchi.chen@intel.com.
Jérémy Compostella has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85226?usp=email )
Change subject: arch/x86: Enable support for IOAPIC devices
......................................................................
Patch Set 1:
(2 comments)
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/85226/comment/1cbadbea_c7865ddf?usp... :
PS1, Line 190: struct device dummy;
What about using `struct device_path path = {0};` instead ?
https://review.coreboot.org/c/coreboot/+/85226/comment/bd91ef28_5182638b?usp... :
PS1, Line 200: memset(&dummy, 0, sizeof(dummy));
I would let he compiler do it. `struct device dummy = {0};`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85226?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie13d4f5c4f0704f0935974f90e5b7cf24e94aab3
Gerrit-Change-Number: 85226
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 16:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No