Patrick Georgi submitted this change.

View Change

vc/amd/agesa: Fix uninitialized scalar variable

AllocParams.Persist is used uninitialized when calling
HeapAllocateBuffer. This could lead to unpredictable or
unintended results. The f15tn and f16 versions of
AmdS3Save.c have already addressed this by initializing
AllocParams.Persist=0 in the same location in the code,
so adding to f14 only.

Change-Id: I2cbfbc4ad14a861e0cd92f130209b3b0f5b76a17
Signed-off-by: Joe Moore <awokd@danwin1210.me>
Found-by: Coverity CID 1241806
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37194
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
---
M src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c b/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
index eeab385..bc5102b 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
@@ -202,7 +202,7 @@
       //
       AllocParams.RequestedBufferSize = EarlyBufferSize + LateBufferSize;
       AllocParams.BufferHandle = AMD_S3_INFO_BUFFER_HANDLE;
-
+      AllocParams.Persist = 0;
       AGESA_TESTPOINT (TpIfBeforeAllocateS3SaveBuffer, &AmdS3SaveParams->StdHeader);
       if (HeapAllocateBuffer (&AllocParams, &AmdS3SaveParams->StdHeader) != AGESA_SUCCESS) {
         if (AGESA_ERROR > ReturnStatus) {

To view, visit change 37194. To unsubscribe, or for help writing mail filters, visit settings.