View Change

1 comment:

• File payloads/libpayload/include/arm/arch/io.h:

  • Patch Set #9, Line 43: #define outl(v, a) write32((void *) (&v), a)

    Yes, Arm only uses MMIO. in/out I/O ports are a totally x86-specific thing. Please remove these. Building any driver that straight-up calls inb()/outb() for an Arm board is an error.

    (Note that CONFIG_LP_IO_ADDRESS_SPACE exists to model this difference and should not be set on Arm, so you should be able to build the 8250 driver without providing these. We're doing that only plenty of boards already, e.g. configs/config.gru.)

To view, visit change 33287. To unsubscribe, or for help writing mail filters, visit settings.