Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33287 ) Change subject: payloads/libpayload: Update the Makefile in the sample directory and made an example configuration for QEMU/ARM. ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/#/c/33287/9/payloads/libpayload/include/arm/arch... File payloads/libpayload/include/arm/arch/io.h: https://review.coreboot.org/#/c/33287/9/payloads/libpayload/include/arm/arch... PS9, Line 43: #define outl(v, a) write32((void *) (&v), a) Yes, Arm only uses MMIO. in/out I/O ports are a totally x86-specific thing. Please remove these. Building any driver that straight-up calls inb()/outb() for an Arm board is an error. (Note that CONFIG_LP_IO_ADDRESS_SPACE exists to model this difference and should not be set on Arm, so you should be able to build the 8250 driver without providing these. We're doing that only plenty of boards already, e.g. configs/config.gru.) -- To view, visit https://review.coreboot.org/c/coreboot/+/33287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32872c43a99357aa966de3582f6fdb2e2652517 Gerrit-Change-Number: 33287 Gerrit-PatchSet: 9 Gerrit-Owner: Asami Doi <d0iasm.pub@gmail.com> Gerrit-Reviewer: Asami Doi <d0iasm.pub@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-CC: Raul Rangel <rrangel@chromium.org> Gerrit-Comment-Date: Tue, 11 Jun 2019 02:55:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment