Patch Set 13:

i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_BERKNIP/bootblock/lib/cbfs.o: in function `cbfs_get_boot_device':
/home/coreboot/node-root/workspace/coreboot-gerrit/src/lib/cbfs.c:373: undefined reference to `_ecbfs_mcache'

src/soc/amd/picasso/memlayout_x86.ld will need to be edited as well. I think it can live just before the ASSERTs just below BOOTBLOCK entry.

Hrmm. I just remembered we're statically laying things out so we'll need to double check addresses.

View Change

To view, visit change 38424. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abd1c813aece6e78fb883f292ce6c9319545c44
Gerrit-Change-Number: 38424
Gerrit-PatchSet: 13
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 08 Oct 2020 22:18:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment