Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )
Change subject: driver/thunderbolt: Driver for allocating hotplug resources
......................................................................
Patch Set 1:
I would rather see the hotplug-part in device/ as a separate commit.
I think there is a hotplug-capability bit in one of the PCIe standard capability blocks that should be evaluated as well. Can you paste lspci -xxxx output of that thunderbolt device somewhere (mailing list would be fine), maybe there is a more generic solution that does not depend on PCI device ID.
The hotplug code should also hook with cardbus bridges.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Mimoja
coreboot@mimoja.de
Gerrit-CC: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 10 Oct 2019 06:56:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment