3 comments:
File src/soc/amd/common/block/acpimmio/mmio_util.c:
Patch Set #7, Line 32: DECLARE_ACPIMMIO_BANK
No reason to use DECLARE_ACPIMMIO_BANK in this block.
File src/soc/amd/common/block/acpimmio/psp_verstage_stub.c:
I would just remove these since we can directly set acpimmio_iomux from psp_verstage.
File src/soc/amd/picasso/i2c.c:
Patch Set #7, Line 55: switch (dev->path.mmio.addr) {
You could just use the i2c_bus_address[x] values? I don't think those case statements will hold up, […]
This is also why I split it off into a different file. It's only needed when generating ACPI tables, which verstage doesn't do.
To view, visit change 42523. To unsubscribe, or for help writing mail filters, visit settings.