Attention is currently required from: Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Subrata Banik, Tarun.
4 comments:
Commit Message:
Patch Set #4, Line 13: minor Rework
Minor rework …
Patch Set #4, Line 13: Major rework is required for Rex P1 and P2.
Why? What is the problem with the current implementation?
GPIO pad configuration for THC1 according to CBI fw_config.
ACPI entries in SSDT for ELAN according to CBI fw_config.
THC0 must be enabled when THC1 is enabled.
Major rework is required for Rex P1 and P2. minor Rework is needed for
EVT. Rex with THC rework won't be able to support UWB and FPCMU.
The touch device must be converted to SPI interface.
When THC is enabled and the THC rework is in place, the UWB and FPMCU
are not supported and need to be disable from the CBI.
THC0 will also be provided with ACPI entries when THC1 is enabled.
THC1 GPIO pins will be configured for THC according to the CBI
TOUCHSCREEN fw_config field.
The resistor on the THC-SPI MISO pin should be 100 Ohm.
For me this reads very heard, as you break the line after every sentence, and often it’s also just a note, and it’s hard to know if these are related, and what problem is addressed exactly.
File src/mainboard/google/rex/variants/rex0/fw_config.c:
Patch Set #4, Line 10: #if CONFIG(SOC_INTEL_TOUCH)
Why is the preprocessor magic needed?
To view, visit change 81333. To unsubscribe, or for help writing mail filters, visit settings.