Attention is currently required from: Furquan Shaikh.
1 comment:
File src/soc/amd/common/block/lpc/espi_util.c:
#define ESPI_DN_TX_HDR0 0x00
enum espi_cmd_type {
CMD_TYPE_SET_CONFIGURATION = 0,
CMD_TYPE_GET_CONFIGURATION = 1,
CMD_TYPE_IN_BAND_RESET = 2,
CMD_TYPE_PERIPHERAL = 4,
CMD_TYPE_VW = 5,
CMD_TYPE_OOB = 6,
CMD_TYPE_FLASH = 7,
};
#define ESPI_DN_TX_HDR1 0x04
#define ESPI_DN_TX_HDR2 0x08
#define ESPI_DN_TX_DATA 0x0c
#define ESPI_MASTER_CAP 0x2c
#define ESPI_VW_MAX_SIZE_SHIFT 13
#define ESPI_VW_MAX_SIZE_MASK (0x3f << ESPI_VW_MAX_SIZE_SHIFT)
#define ESPI_GLOBAL_CONTROL_1 0x34
#define ESPI_SUB_DECODE_SLV_SHIFT 3
#define ESPI_SUB_DECODE_SLV_MASK (0x3 << ESPI_SUB_DECODE_SLV_SHIFT)
#define ESPI_SUB_DECODE_EN (1 << 2)
#define SLAVE0_INT_STS 0x70
#define ESPI_STATUS_DNCMD_COMPLETE (1 << 28)
#define ESPI_STATUS_NON_FATAL_ERROR (1 << 6)
#define ESPI_STATUS_FATAL_ERROR (1 << 5)
#define ESPI_STATUS_NO_RESPONSE (1 << 4)
#define ESPI_STATUS_CRC_ERR (1 << 2)
#define ESPI_STATUS_WAIT_TIMEOUT (1 << 1)
#define ESPI_STATUS_BUS_ERROR (1 << 0)
#define ESPI_RXVW_POLARITY 0xac
I wonder why these are in the .c file and not in the .h file like the rest of the defines. […]
These are AMD specific, while I think the .h is eSPI spec specific.
To view, visit change 41272. To unsubscribe, or for help writing mail filters, visit settings.