Attention is currently required from: Angel Pons, Erik van den Bogaert, Felix Singer, Frans Hendriks, Jan Samek, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nicholas Sudsgaard, Piotr Król, Sean Rhodes, Tim Crawford.
View Change
1 comment:
Patchset:
Patch Set #2:
Your patch shouldn't change device state. […]
The important part is that we carefully look into the cases where FSP and coreboot
settings disagree.
So what is you suggestion to do with this patch now? Wait that yours are reviewed
and then wait until somebody re-works this one?
To view, visit change 79917. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f7e3e1dc6b3d8d6159bd4701e6fd90f4b0f67f4
Gerrit-Change-Number: 79917
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Jan Samek <jan.samek@siemens.com>
Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean@starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford@system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Attention: Jeremy Soller <jeremy@system76.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Jan Samek <jan.samek@siemens.com>
Gerrit-Attention: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Attention: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Attention: Tim Crawford <tcrawford@system76.com>
Gerrit-Attention: Sean Rhodes <sean@starlabs.systems>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Comment-Date: Mon, 15 Jan 2024 16:22:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Jan Samek <jan.samek@siemens.com>
Gerrit-MessageType: comment