Patch Set 9:
anything needs to do with this patch?
Other than two comments left by Arthur, I think it's good.
Patch set 10:Code-Review +1
9 comments:
Patch Set #3, Line 10: CML-U RVP to RVPU to avoid confusing
OKAY. […]
Done
File src/mainboard/intel/coffeelake_rvp/Kconfig:
config DEVICETREE
string
default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
okay. will do.
Done
File src/mainboard/intel/coffeelake_rvp/Kconfig:
Patch Set #6, Line 18: || BOARD_INTEL_COFFEELAKE_RVP8
good catch.
Done
Patch Set #6, Line 47: || BOARD_INTEL_COMETLAKE_RVP8
good catch. done.
Done
File src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd:
Patch Set #3, Line 5: SI_GBE@0x81000 0x2000
Your comment is correct. Will revise it.
Arthur, is this correct now?
File src/mainboard/intel/coffeelake_rvp/variants/cml_s/devicetree.cb:
newline at the end.
Is this still applicable?
File src/mainboard/intel/coffeelake_rvp/variants/cml_s/overridetree.cb:
Patch Set #10, Line 73: register "PcieRpEnable[0]" = "0"
I think you can omit disabled PCIe root ports, as the default value is zero
Patch Set #10, Line 91: register "PcieRpEnable[4]" = "1"
Maybe add a comment that these are for the Thunderbolt controller
Patch Set #10, Line 151: Tunderbolt
typo: missing "h" in Thunderbolt
To view, visit change 36685. To unsubscribe, or for help writing mail filters, visit settings.