3 comments:
File src/southbridge/intel/common/spi.h:
I think the (function) names should reflect that this is about the `opmenu` […]
ok
Patch Set #2, Line 36: void intel_southbridge_override_spi(struct intel_spi_config *spi_config);
If this is going to be implemented by the mainboard code, it should […]
There is the sandybridge code that unconditionally sets the opcodes from devicetree and then there what I try to do on lenovo x60 (runtime check for a flash)...
File src/southbridge/intel/common/spi.c:
Patch Set #2, Line 1054: /* WRSR: Write Status Register */
aligning these comments would look much better, I guess
ok
To view, visit change 33036. To unsubscribe, or for help writing mail filters, visit settings.