Attention is currently required from: Angel Pons, Michael Büchler, Michael Niewöhner, Michał Żygowski, Nicholas Chin, Paul Menzel.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port ......................................................................
Patch Set 30:
(6 comments)
File src/mainboard/dell/optiplex_9020/Kconfig:
https://review.coreboot.org/c/coreboot/+/55232/comment/39c3fde7_990e365a : PS30, Line 22: hex
Symbol type is not necessary as it is defined in the src/Kconfig
Done
https://review.coreboot.org/c/coreboot/+/55232/comment/b371d932_c2afeecf : PS30, Line 26: string
Symbol type not necessary
Done
https://review.coreboot.org/c/coreboot/+/55232/comment/cd0d05a9_3e83148f : PS30, Line 30: string
Symbol type not necessary
Done
File src/mainboard/dell/optiplex_9020/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/55232/comment/3466ff15_c4ff8dbd : PS30, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Should be […]
Done
File src/mainboard/dell/optiplex_9020/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/55232/comment/e1e95fdb_639619f7 : PS30, Line 1: GPL-2.0-only
CC-PDDC, see my comment on ec. […]
Done
File src/mainboard/dell/optiplex_9020/overridetree_mt.cb:
https://review.coreboot.org/c/coreboot/+/55232/comment/8eea0855_6ec59d4d : PS30, Line 6: birdge
bridge
Done