AFAIUI, the current default is meant to make Intel wireless cards work by default, since different people have different hardware configurations.
[...] and makes the default configuration for a board more likely to work well.

This is why NO_INTEL_WIFI is going to be enabled only at systems where it is highly improbable to meet the Intel PCI-e WiFi module. For example, you can't meet Intel WiFi at Emulation boards, but DRIVERS_INTEL_WIFI is erroneously enabled even for such boards.

It does no harm to those without such hardware, and anyone who doesn't want to use the driver can disable it in Kconfig.

It consumes a few kilobytes at CBFS, and after seeing that all the other Generic Drivers are disabled by default I can't understand why there should be made an exception for Intel.

View Change

To view, visit change 31219. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia21a141e25e58f6126a6d48d83cdfb4f746f3320
Gerrit-Change-Number: 31219
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Comment-Date: Sun, 03 Feb 2019 18:34:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment