Attention is currently required from: Arthur Heymans, Felix Singer, Nico Huber.
Patch set 1:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #1:
I think we want NO_EARLY_GFX_INIT set in this case, but by adding the depends on to the choice statement, both MAINBOARD_USE_EARLY_LIBGFXINIT and NO_EARLY_GFX_INIT are set to 0.
Is this really what was intended here? I mean, it may not matter in the long run, because NO_EARLY_GFX_INIT isn't actually used anywhere. Why is this even a choice instead of a simple config option?
To view, visit change 79668. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0447d440009d6dcf8c1f911672156e159d810cf
Gerrit-Change-Number: 79668
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Comment-Date: Sun, 14 Jan 2024 01:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment