Attention is currently required from: Subrata Banik, Michael Niewöhner, EricR Lai.
7 comments:
File src/mainboard/intel/adlrvp/devicetree.cb:
NB. This can also be set inside the respective `device pci` node, now.
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #47, Line 34: die("Unsupported pcie_rp_type!");
Nit, it's dead code. Maybe an assert() would be better.
Patch Set #47, Line 48: m_cfg->PcieClkSrcClkReq[cfg[i].clk_src] = cfg[i].clk_req;
Why skip the assignment? What is the default value and does it have
special meaning?
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
Patch Set #47, Line 22: PCIE_RP_CLK_FREE = (1 << 3),
I'm a bit confused here. Doesn't this usually mean the clock is used for
something else, i.e. not an RP? if not, what's the exact difference to
CLK_REQ_UNUSED?
Nit, needs a line break here to comply to our coding style. Or the alternative
block style without dangling asterisks.
Patch Set #47, Line 104: uint32_t flags;
Nit, `enum pcie_rp_flags` I assume? That would also make the comment obsolete.
Why not keep it together with the flags declaration?
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.