6 comments:
File src/cpu/x86/smm/smm_save_state.c:
Patch Set #2, Line 24: void *
use uint8_t * here?
Patch Set #2, Line 34: return base;
I feel like this logic should be tied to the code doing the SMM memory layout. And not carrying those assumptions to another piece of code. Looks like you lifted it from smm_get_save_state() in src/cpu/x86/smm/smm_module_handler.c which is where it should belong.
Patch Set #2, Line 41: 0x8000 - 0x7efc
Don't we have some defines for this?
Patch Set #2, Line 258: int smm_save_state_ops_init(const struct smm_runtime *runtime)
And this would get called as one of the first things in the SMM entry point?
Patch Set #2, Line 261: smm_runtime = runtime;
comment this for its purposes.
File src/include/cpu/x86/smm.h:
Patch Set #2, Line 124: int smm_save_state_ops_init(const struct smm_runtime *runtime);
Document the functions, please.
To view, visit change 36661. To unsubscribe, or for help writing mail filters, visit settings.