10 comments:
Patch Set #3, Line 27: .quad 0
Is it u64 so just one quad? Or two long and no preprocessor here.
Patch Set #3, Line 38: #endif
We are not consistent about this, perhaps .code without indent?
Patch Set #3, Line 89: and $(~0xf), %sp
%rsp ?
Patch Set #3, Line 110: pop %rbx
I don't know what our preference is about using GAS macros. Popping 64bit from stack to edx.eax would be good candidate here. I believe this entire change would reduce to having that macro defined differently (using that shr $32, %rax) on __x86_64__.
Patch Set #3, Line 115: mov $(MTRR_PHYS_BASE(0)), %rcx
Why %rax instead of %eax here? Same for %ecx, %edx.
Patch Set #3, Line 120: inc %rcx
%ecx ?
Patch Set #3, Line 143: dec %rbx
%ecx %ebx
Patch Set #3, Line 151: or $(MTRR_DEF_TYPE_EN), %rax
%eax and %ecx
Patch Set #3, Line 40: .align 4
Is this enough for x86_64?
Patch Set #3, Line 42: /* selgdt 0, unused */
Adding this is not x86_64 related change?
To view, visit change 30500. To unsubscribe, or for help writing mail filters, visit settings.