Felix Singer has uploaded this change for review.

View Change

tgl,adl,rpl mainboards: Drop superfluous cpu_cluster device

The cpu_cluster device is defined in the chipset devicetree. So drop it
from the mainboards.

Change-Id: Ib84e7804c03f1c0779ab7053a09e397a267a3844
Signed-off-by: Felix Singer <felixsinger@posteo.net>
---
M src/mainboard/intel/adlrvp/devicetree_m.cb
M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
M src/mainboard/system76/adl/devicetree.cb
M src/mainboard/system76/rpl/devicetree.cb
M src/mainboard/system76/tgl-h/devicetree.cb
M src/mainboard/system76/tgl-u/devicetree.cb
9 files changed, 0 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/83523/1
diff --git a/src/mainboard/intel/adlrvp/devicetree_m.cb b/src/mainboard/intel/adlrvp/devicetree_m.cb
index 70a8706..ec60894 100644
--- a/src/mainboard/intel/adlrvp/devicetree_m.cb
+++ b/src/mainboard/intel/adlrvp/devicetree_m.cb
@@ -6,8 +6,6 @@
end
chip soc/intel/alderlake

- device cpu_cluster 0 on end
-
# GPE configuration
# Note that GPE events called out in ASL code rely on this
# route. i.e. If this route changes then the affected GPE
diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
index 932a5c7..fb55da4 100644
--- a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
@@ -1,7 +1,5 @@
chip soc/intel/alderlake

- device cpu_cluster 0 on end
-
# GPE configuration
# Note that GPE events called out in ASL code rely on this
# route. i.e. If this route changes then the affected GPE
diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
index 2437880..bbc428e 100644
--- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
@@ -38,8 +38,6 @@
register "pmc_gpe0_dw2" = "GPP_E"

# Device Tree
- device cpu_cluster 0 on end
-
device domain 0 on
device ref igpu on
register "ddi_portA_config" = "1"
diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
index 22f824f..7a3f9fb 100644
--- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
@@ -30,8 +30,6 @@
register "pmc_gpe0_dw2" = "GPP_E"

# Device Tree
- device cpu_cluster 0 on end
-
device domain 0 on
device ref igpu on
register "ddi_portA_config" = "1"
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
index 2b7c4f8..c29d7c9 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
@@ -63,8 +63,6 @@
register "PcieClkSrcClkReq[6]" = "PCIE_CLK_NOTUSED"

# Actual device tree.
- device cpu_cluster 0 on end
-
device domain 0 on
device ref igpu on end
device ref dptf on end
diff --git a/src/mainboard/system76/adl/devicetree.cb b/src/mainboard/system76/adl/devicetree.cb
index 9a7a149..c73bef2c 100644
--- a/src/mainboard/system76/adl/devicetree.cb
+++ b/src/mainboard/system76/adl/devicetree.cb
@@ -19,8 +19,6 @@
# Thermal
register "tcc_offset" = "8"

- device cpu_cluster 0 on end
-
device domain 0 on
device ref system_agent on end
device ref igpu on
diff --git a/src/mainboard/system76/rpl/devicetree.cb b/src/mainboard/system76/rpl/devicetree.cb
index 749ce53..34105fc 100644
--- a/src/mainboard/system76/rpl/devicetree.cb
+++ b/src/mainboard/system76/rpl/devicetree.cb
@@ -23,8 +23,6 @@
# seen on J0 and Q0 SKUs
register "disable_package_c_state_demotion" = "1"

- device cpu_cluster 0 on end
-
device domain 0 on
device ref system_agent on end
device ref igpu on
diff --git a/src/mainboard/system76/tgl-h/devicetree.cb b/src/mainboard/system76/tgl-h/devicetree.cb
index 11b85ce..58a4fcf 100644
--- a/src/mainboard/system76/tgl-h/devicetree.cb
+++ b/src/mainboard/system76/tgl-h/devicetree.cb
@@ -77,8 +77,6 @@
register "pmc_gpe0_dw2" = "PMC_GPP_D"

# Actual device tree
- device cpu_cluster 0 on end
-
device domain 0 on
#From CPU EDS(575683)
device ref system_agent on end
diff --git a/src/mainboard/system76/tgl-u/devicetree.cb b/src/mainboard/system76/tgl-u/devicetree.cb
index ae80a32..d7a527a 100644
--- a/src/mainboard/system76/tgl-u/devicetree.cb
+++ b/src/mainboard/system76/tgl-u/devicetree.cb
@@ -65,8 +65,6 @@
register "tcc_offset" = "12"

# Actual device tree
- device cpu_cluster 0 on end
-
device domain 0 on
device ref system_agent on end
device ref igpu on

To view, visit change 83523. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib84e7804c03f1c0779ab7053a09e397a267a3844
Gerrit-Change-Number: 83523
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit@felixsinger.de>